Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sphinx theme #4367

Merged
merged 26 commits into from
Sep 22, 2023
Merged

docs: update sphinx theme #4367

merged 26 commits into from
Sep 22, 2023

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Replaces #4263

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #4367 (9670947) into main (e340be1) will not change coverage.
The diff coverage is n/a.

❗ Current head 9670947 differs from pull request most recent head 72b136a. Consider uploading reports for the commit 72b136a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #4367   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files         318      318           
  Lines       21171    21171           
=======================================
  Hits        18868    18868           
  Misses       2303     2303           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/conf.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the one suggested URL fix

@cmatsuoka cmatsuoka changed the title Sphinx docs: update sphinx theme Sep 20, 2023
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there's a linting error to address.

@mr-cal
Copy link
Collaborator

mr-cal commented Sep 21, 2023

tox run -e build-docs doesn't work for me on this branch, looks like CI is failing for a similar reason on tox run -e lint-docs

@sergiusens
Copy link
Collaborator Author

I mostly picked this up verbatim, @lengau would you know what's going on?

Signed-off-by: Callahan Kovacs <[email protected]>
@lengau
Copy link
Contributor

lengau commented Sep 22, 2023

I think @mr-cal's PR #4375 got it :-)

Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
Copy link
Collaborator

mr-cal commented Sep 22, 2023

Yep, that and 3 minor changes here. I think we're good to go.

Co-authored-by: Alex Lowe <[email protected]>
@mr-cal mr-cal merged commit aa64666 into main Sep 22, 2023
13 checks passed
@mr-cal mr-cal deleted the sphinx branch September 22, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants